Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Trigger NatssChannel reconciliation in case of errors #764

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Trigger NatssChannel reconciliation in case of errors #764

merged 1 commit into from
Nov 29, 2019

Conversation

marcobebway
Copy link
Contributor

@marcobebway marcobebway commented Nov 29, 2019 •
edited
Loading

Description

Fix the NatssChannel not ready state caused by restarting the natss-dispatcher and not being able to connect to the nats server before reconciliation.

Proposed Changes

Requeue NatssChannel reconciliation in case of errors.

Release Note

Requeue NatssChannel reconciliation in case of errors.

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 29, 2019
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 29, 2019
@knative-prow-robot knative-prow-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 29, 2019
@knative-prow-robot
Copy link
Contributor

Hi @marcobebway. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marcobebway
Copy link
Contributor Author

/assign @Abd4llA

@devguyio
Copy link
Contributor

/ok-to-test

@knative-prow-robot knative-prow-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2019
@devguyio
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2019
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Abd4llA, marcobebway

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2019
@knative-prow-robot knative-prow-robot merged commit 690293c into knative:release-0.10 Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devguyio devguyio Awaiting requested review from devguyio

@n3wscott n3wscott Awaiting requested review from n3wscott

Assignees

@devguyio devguyio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcobebway @knative-prow-robot @devguyio @googlebot